Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a temp path to save local checkpoints for remote save path #3671

Closed
wants to merge 3 commits into from

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 21, 2024

What does this PR do?

Uses a temp path to save local checkpoints for remote save paths.

This avoids issues where the current path has limits on file sizes or permission restrictions. This also enables more configurability because we can configure the default temp dir if needed.

Testing

Tested on interactive, saving to a remote dbfs path. You can see that the checkpoints are now saved to a local folder:
image

And the checkpoints are uploaded correctly to the remote location in mlflow artifacts:
image

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@irenedea irenedea requested a review from bigning October 21, 2024 22:04
@irenedea
Copy link
Contributor Author

closing in favor of #3673

@irenedea irenedea closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant